Re: [PATCH v10 0/5] drivers/perf: add Synopsys DesignWare PCIe PMU driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 16 Nov 2023, Shuai Xue wrote:
On 2023/11/16 08:57, Ilkka Koskinen wrote:

Hi Shuai,

On Sat, 4 Nov 2023, Shuai Xue wrote:
Change Log
==========

- move the &plat_dev->dev to previous line to warp more beautiful (Per Jonathan)
- rename error label with the same suffix 'err'  (Per Jonathan)
- drop unnecessary else branch and return directly (Per Baolin)
- warp out set prev_count from dwc_pcie_pmu_set_period (Per Baolin)
- use PMU_FORMAT_ATTR to simplify format sysfs stuff (Per Will)
- export pci_clear_and_set_dword() to simplify _enable() functions  (Per Will)
- simplify _read() function by unconditionally calculate with unit in bytes plused if branch for group#1 event (Per Will and Robin)
- simplify _update() function by unconditionally mask with 64-bit width plused if branch for lane event (Per Will)
- add type sanity check in _init() (Per Will)
- test with fuzzing tool before this new version (Per Will)
- register a platform device for each PCI device to probe RAS_DES PMU cap (Per Robin)
- add dwc_pcie_vendor_ids to extend vendor id for future added device (Per Krishna)
- pickup review-by tag from Baolin, Yicong and Jonathan

...

Shuai Xue (5):
 docs: perf: Add description for Synopsys DesignWare PCIe PMU driver
 PCI: Add Alibaba Vendor ID to linux/pci_ids.h
 PCI: move pci_clear_and_set_dword helper to pci header
 drivers/perf: add DesignWare PCIe PMU driver
 MAINTAINERS: add maintainers for DesignWare PCIe PMU driver

As I mentioned earlier, I successfully tested your patchset with a few patches on top of it to enable DWC PCIe PMU on AmpereOne. Thus, feel free to add this tag to all the patches above:

    Tested-by: Ilkka Koskinen <ilkka@xxxxxxxxxxxxxxxxxxxxxx>

Br, Ilkka

Hi, Ilkka,

Thank you.

I will add your tested-by tag in the upcoming version v11. However, I
kindly request some time to wait for feedback from esteemed maintainers such
as Will, and Robin.

Sounds good. Actually, I can give you a little feedback on the driver patch meanwhile.

--Ilkka


Cheers,
Shuai

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux