On 06/11/2023 07:12, Jian Yang wrote: > From: "jian.yang" <jian.yang@xxxxxxxxxxxx> > > Add new properties to support control power supplies and reset pin of > a downstream component. > > Signed-off-by: jian.yang <jian.yang@xxxxxxxxxxxx> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > --- > .../bindings/pci/mediatek-pcie-gen3.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > index 7e8c7a2a5f9b..a4f6b48d57fa 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > @@ -84,6 +84,26 @@ properties: > items: > enum: [ phy, mac ] > > + vpcie1v8-supply: > + description: > + The regulator phandle that provides 1.8V power from root port to a > + downstream component. > + > + vpcie3v3-supply: > + description: > + The regulator phandle that provides 3.3V power from root port to a > + downstream component. > + > + vpcie12v-supply: > + description: > + The regulator phandle that provides 12V power from root port to a > + downstream component. > + > + dsc-reset-gpios: > + description: > + The extra reset pin other than PERST# required by a downstream component. > + maxItems: 1 How did you implement Rob's feedback? Or did you just ignore it? This does not look like property of the controller. Aren't you now trying to implement power-sequencing of devices via properties of host controller? Best regards, Krzysztof
