In "PCI/sysfs: add per pci device msi[x] irq listing (v5)" error handling in said function got broken afaict: "ret" gets set to zero (success), and control gets transferred to the "error" label. In contrast, msi_capability_init() properly cleans up in that case. While doing proper cleanup here would certainly be possible here, I wonder whether treating failure to set up these sysfs entries as an error condition is appropriate here in the first place. Additionally it appears to me that populate_msi_sysfs() has incomplete error handling too - kset_unregister() isn't being called, and pdev->msi_kset is left set to non-NULL. Thanks, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
