On Fri, Oct 20, 2023 at 11:21:07AM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > pci_host_common_remove() returned zero unconditionally. With that > converted to return void instead, the generic pci host driver can be > switched to .remove_new trivially. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/pci/controller/pci-host-common.c | 4 +--- > drivers/pci/controller/pci-host-generic.c | 2 +- > include/linux/pci-ecam.h | 2 +- > 3 files changed, 3 insertions(+), 5 deletions(-) Acked-by: Will Deacon <will@xxxxxxxxxx> Will
