[+Cc Ricky] On Mon, Sep 18, 2023 at 8:23 PM Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > Hi Ilpo, > > On Mon, Sep 18, 2023 at 03:17:41PM +0300, Ilpo Järvinen wrote: > > > > > + */ > > > > > + val = cap[1] & PCI_EXP_LNKCTL_ASPMC; > > > > Given this line, it just felt pretty obvious because why would the code > > & PCI_EXP_LNKCTL_* with some random register (value) that isn't LNKCTL :-). > > That's a fair point :) Okay I can drop the comment in the next version. We are seeing Realtek cardreader 5261 stops working after S3 resume, and this patch can fix the issue. So please collect my tag: Tested-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>