Re: [PATCH v2] PCI/ASPM: Add back L1 PM Substate save and restore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ilpo,

On Mon, Sep 18, 2023 at 03:17:41PM +0300, Ilpo Järvinen wrote:
> > > > +	 */
> > > > +	val = cap[1] & PCI_EXP_LNKCTL_ASPMC;
> 
> Given this line, it just felt pretty obvious because why would the code 
> & PCI_EXP_LNKCTL_* with some random register (value) that isn't LNKCTL :-).

That's a fair point :) Okay I can drop the comment in the next version.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux