Hi Sato-san, On Wed, Sep 13, 2023 at 11:24 AM Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/renesas,sh7751-pci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas SH7751 PCI Host controller > + > +maintainers: > + - Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> > + > +properties: > + compatible: > + - items: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml: Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml:14:7: [warning] wrong indentation: expected 4 but found 6 (indentation) > + - enum: > + - renesas,r2d-pci # Renesas RTS7751R2D board Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml:16:32: [error] syntax error: found character '\t' that cannot start any token (syntax) > + - iodata,julian-pci # IO DATA DEVICE Julian board Please drop the two board-specific compatible values, they do not represent different implementations of the PCI core in the SH7751 SoC. > + - const: renesas,sh7751-pci > + > + reg: > + minItems: 3 > + > + interrupt-cells: > + const: 1 > + > + address-cells: > + const: 3 > + > + size-cells: > + const: 2; > + > + range: > + description: | > + The PCI bus memory area and I/O area. > + > + > +required: > + - compatible > + - reg > + - interrupt-cells > + - address-cells > + - size-cells > + - range > + > +examples: > + - | > + pci@fe200000 { Please align "pci" with the "|" above > + compatible = "renesas,sh7751-pci"; Please indent by 4 spaces > + #address-cells = <3>; > + #size-cells = <2>; > + ranges = <0x02000000 0 0xfd000000 0xfd000000 0 0x01000000>, > + <0x01000000 0 0xfe240000 0xfe240000 0 0x00040000>; > + reg = <0xfe200000 0x0400>, > + <0x0c000000 0x04000000>, > + <0xff800000 0x0030>; > + #interrupt-cells = <1>; Documentation/devicetree/bindings/pci/renesas,sh7751-pci.example.dtb: pci@fe200000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus.yaml# > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
