On 13/09/2023 11:23, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> You did not resolve several comments from previous version. I don't understand why, so I just assume this is not ready for review. Just quick look tells this wasn't tested and has multiple issues. Maybe that was the intention, but nothing is described in commit log confirming such intention. Therefore to be clear: that's a NAK. Also, standard template: Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
