On Fri, Mar 9, 2012 at 9:37 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Fri, Mar 9, 2012 at 10:32 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >> On Fri, Mar 9, 2012 at 9:25 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >>> >>> Well, it looks like you can change both save_dev_dmaru() *and* >>> get_dev_dmaru() to take a struct pci_dev *. I assumed that would be >>> obvious. >> >> no. >> >> get_dev_dmaru() have to use bus/devfn to retrieve the dev pointer. > > I expected something like that, but all I see in the patch is this: > > +static void restore_dev_to_drhd(struct pci_dev *dev) > + drhd = get_dev_dmaru(pci_domain_nr(dev->bus), dev->bus->number, > + dev->devfn, &i, &saved_dev_drhd_list); > > +static void restore_dev_to_atsr(struct pci_dev *dev) > + atsr = get_dev_dmaru(pci_domain_nr(dev->bus), dev->bus->number, > + dev->devfn, &i, &saved_dev_atsr_list); > > In both those cases, you have the struct pci_dev *. OK, i missed that. will update that accordingly. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
