Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Correct the short interval between PTM requests.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


[Cc: +Vinicius]

Dear Sasha,

Am 18.07.23 um 18:15 schrieb Neftin, Sasha:
On 7/17/2023 20:32, Paul Menzel wrote:
[Cc: +linux-pci@xxxxxxxxxxxxxxx]


Maybe be more specific in the commit message summary. Maybe:

igc: Decrease PTM short interval from 10 us to 1 us


Am 17.07.23 um 19:19 schrieb Sasha Neftin:
With the 10us interval, we were seeing PTM transactions taking around 12us.
With the 1us interval, PTM dialogs took around 2us. Checked with the
PCIe sniffer.

On what board, and with what device and what firmware versions?

Any with the PTM support. HW feature and not dependent on the firmware.

Still you tested it. It’s always beneficial to at least denote one of the systems with all the details. Especially as it shouldn’t cost you more than a minute to add these details.

Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()")
Suggested-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>
Signed-off-by: Sasha Neftin <sasha.neftin@xxxxxxxxx>
  drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h
index 44a507029946..c3722f524ea7 100644
--- a/drivers/net/ethernet/intel/igc/igc_defines.h
+++ b/drivers/net/ethernet/intel/igc/igc_defines.h
@@ -549,7 +549,7 @@
  #define IGC_PTM_CTRL_SHRT_CYC(usec)    (((usec) & 0x2f) << 2)
  #define IGC_PTM_CTRL_PTM_TO(usec)    (((usec) & 0xff) << 8)
-#define IGC_PTM_SHORT_CYC_DEFAULT    10  /* Default Short/interrupted cycle interval */
+#define IGC_PTM_SHORT_CYC_DEFAULT    1   /* Default short cycle interval */

Why is the comment updated?

Interval, not interrupt...

Sorry, I do not understand your answer. It’d be great, if you elaborated.

  #define IGC_PTM_CYC_TIME_DEFAULT    5   /* Default PTM cycle time */
  #define IGC_PTM_TIMEOUT_DEFAULT        255 /* Default timeout for PTM errors */

Kind regards,


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux