Re: [PATCH v2 3/8] PCI: epf-mhi: Add dtate change op

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 7/7/2023 11:29 AM, Manivannan Sadhasivam wrote:
On Fri, Jun 30, 2023 at 04:22:06PM +0530, Krishna chaitanya chundru wrote:
Add dstate host op for MHI EPF.

Use "D-state" everywhere. Also the subject should be:

"PCI: epf-mhi: Add support for handling D-state notification from EPC"

Fix the commit message accordingly.
I will change it as you suggested.

Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx>
---
  drivers/pci/endpoint/functions/pci-epf-mhi.c | 13 +++++++++++++
  include/linux/mhi_ep.h                       |  3 +++
  2 files changed, 16 insertions(+)

diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
index 9c1f5a1..64ff37d 100644
--- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
+++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
@@ -339,6 +339,18 @@ static int pci_epf_mhi_bme(struct pci_epf *epf)
  	return 0;
  }
+static int pci_epf_mhi_dstate_change(struct pci_epf *epf, pci_power_t state)
+{
+	struct pci_epf_mhi *epf_mhi = epf_get_drvdata(epf);
+	struct mhi_ep_cntrl *mhi_cntrl = &epf_mhi->mhi_cntrl;
+	struct device *dev = &epf->dev;
+
+	mhi_cntrl->dstate = state;
+	dev_info(dev, "D-state changeg to %s\n", pci_power_name(state));
This can be removed since we already print the state in pci driver.

- Mani

ok

- KC


+
+	return 0;
+}
+
  static int pci_epf_mhi_bind(struct pci_epf *epf)
  {
  	struct pci_epf_mhi *epf_mhi = epf_get_drvdata(epf);
@@ -394,6 +406,7 @@ static struct pci_epc_event_ops pci_epf_mhi_event_ops = {
  	.link_up = pci_epf_mhi_link_up,
  	.link_down = pci_epf_mhi_link_down,
  	.bme = pci_epf_mhi_bme,
+	.dstate_change = pci_epf_mhi_dstate_change,
  };
static int pci_epf_mhi_probe(struct pci_epf *epf,
diff --git a/include/linux/mhi_ep.h b/include/linux/mhi_ep.h
index f198a8a..c3a0685 100644
--- a/include/linux/mhi_ep.h
+++ b/include/linux/mhi_ep.h
@@ -8,6 +8,7 @@
#include <linux/dma-direction.h>
  #include <linux/mhi.h>
+#include <linux/pci.h>
#define MHI_EP_DEFAULT_MTU 0x8000 @@ -139,6 +140,8 @@ struct mhi_ep_cntrl { enum mhi_state mhi_state; + pci_power_t dstate;
+
  	u32 max_chan;
  	u32 mru;
  	u32 event_rings;
--
2.7.4




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux