On Mon, May 15, 2023 at 01:56:25PM -0700, Smita Koralahalli wrote: > Could I please know, why do you think masking surprise down during > initialization would be a better approach than reading surprise down error > status on a DPC event? Because in both approaches we should be however > clearing status registers right? Masking seemed much simpler, more elegant, less code. I wasn't aware that masking the error merely suppresses the message to the Root Complex plus the resulting interrupt, but still logs the error. That's kind of a bummer, so I think your approach is fine and I've just sent you some review feedback on your patch. Thanks, Lukas
