Hi Frank, > From: Frank Li, Sent: Tuesday, May 9, 2023 11:00 PM > > > - return -EINVAL; > > + ret = dw_pcie_ep_send_msg(ep, func_no, PCI_CODE_ASSERT_INTA, > > + PCI_MSG_ROUTING_LOCAL); > > + if (ret) > > + return ret; > > + > > + /* > > + * The documents of PCIe and the controller don't mention how long > > + * the INTx should be asserted. If 10 usec, sometimes it failed. > > + * So, asserted for 50 usec. > > + */ > > + usleep_range(50, 100); > > [Frank Li] At least, comments should be updated. It should be level irq. > Here is edge trigger because frame still not supported yet. Will improve > Later or some things. Otherwise comments is misleading. Thank you for your comment! I think so. I'll update the comments on v16. Best regards, Yoshihiro Shimoda > > + > > + return dw_pcie_ep_send_msg(ep, func_no, > > PCI_CODE_DEASSERT_INTA, > > + PCI_MSG_ROUTING_LOCAL); > > }
