RE: [EXT] [PATCH v15 08/22] PCI: designware-ep: Add INTx IRQs support

[Frank Li <frank.li@xxxxxxx>]

> -       return -EINVAL;
> +       ret = dw_pcie_ep_send_msg(ep, func_no, PCI_CODE_ASSERT_INTA,
> +                                 PCI_MSG_ROUTING_LOCAL);
> +       if (ret)
> +               return ret;
> +
> +       /*
> +        * The documents of PCIe and the controller don't mention how long
> +        * the INTx should be asserted. If 10 usec, sometimes it failed.
> +        * So, asserted for 50 usec.
> +        */
> +       usleep_range(50, 100);

[Frank Li] At least, comments should be updated. It should be level irq. 
Here is edge trigger because frame still not supported yet.  Will improve
Later or some things. Otherwise comments is misleading.

> +
> +       return dw_pcie_ep_send_msg(ep, func_no,
> PCI_CODE_DEASSERT_INTA,
> +                                  PCI_MSG_ROUTING_LOCAL);
>  }