Hi Wolfram,
On Mon, May 8, 2023 at 12:46 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Support regulators found on the e.g. KingFisher board.
... for the mini-PCIe slot.
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
> @@ -68,6 +68,12 @@ properties:
> phy-names:
> const: pcie
>
> + vpcie1v5-supply:
> + description: The 1.5v regulator to use for PCIe.
+1.5V is only present on mini-PCIe slots...
> +
> + vpcie3v3-supply:
> + description: The 3.3v regulator to use for PCIe.
... while +3.3V is present on PCIe, mini-PCIe, and M2 PCIe slots.
In addition, normal PCIe slots also have +12V.
So I think it would be prudent to add a vpcie12v0-supply property, too.
W.r.t. to the actual naming, I don't know if there's already a (de facto)
standard for that?
> +
> required:
> - compatible
> - reg
> @@ -121,5 +127,7 @@ examples:
> clock-names = "pcie", "pcie_bus";
> power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
> resets = <&cpg 319>;
> + vpcie1v5-supply = <&pcie_1v5>;
> + vpcie3v3-supply = <&pcie_3v3>;
> };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
