Re: [PATCH v3] pci: controller: pci-ftpci100: Release the clock resources

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, May 8, 2023 at 8:59 AM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:

> completely unrelated to your patch, but this comments state "optional".
> The code below seems to make both clocks mandatory.
> Moreover, a few lines later, we have:
>      if (!IS_ERR(p->bus_clk)) {
> which seems to say that bus_clk is optional.
> This was introduced by 2eeb02b28579.
> Just a guess, but either the comment should be updated, or the code
> modified.

It's fine to make the clocks mandatory, because all Gemini
systems provide these clocks.

But that is good to mention in the commit message as well.

Linus Walleij

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux