Re: [PATCH] PCI: revert "Enable PASID only when ACS RR & UF enabled on upstream path"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/1/11 21:44, Jason Gunthorpe wrote:
iommu_enable_pci_caps() in the Intel IOMMU driver. This also does some
handling for ATS, so here we could check the info->ats_supported flag if ACS
needs to be checked or not.
*groan*  this is seems wrong 🙁 Lu why are we doing this inside iommu
drivers instead of in the device drivers to declare they want to use
PASID?

Currently it's common to enable pasid in the IOMMU drivers, but device
driver has more knowledge of the device, hence it makes more sense to
move pci_enable_pasid() to the device driver.

--
Best regards,
baolu



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux