On Wed, Jan 11, 2023 at 09:57:45AM +0100, Christian König wrote: > This reverts commit 201007ef707a8bb5592cd07dd46fc9222c48e0b9. > > It's correct that the PCIe fabric routes Memory Requests based on the > TLP address, but enabling the PASID mapping doesn't necessary mean that > Memory Requests will have a PASID associated with them. It is true, the routine assumes the device will use untranslated requests with the PASID. > The alternative is ATS which lets the device resolve the PASID+addr pair > before a memory request is made into a routeable TLB address through the > TA. Those resolved addresses are then cached on the device instead of > in the IOMMU TLB. We should pass in a flag "device always sets the translated bit for PASID" and skip the ACS check in that case. The ACS check is not wrong, and it is definately necessary for devices that do not guarentee ATS and PASID are used together, we should not be removing it. Given adding the flag is trivial we should just fix it, not revert this. Jason
