Re: [PATCH 18/21] PCI: Fix cardbus bridge resources as optional size handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 27, 2012 at 01:37:44PM -0800, Yinghai Lu wrote:
> On Fri, Jan 27, 2012 at 10:23 AM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
> > On Sat, 21 Jan 2012 02:08:34 -0800
> > Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> >
> >> We should not set the requested size to -2.
> >>
> >> that will confuse the resource list sorting with align when SIZEALIGN is used.
> >>
> >> Change to STARTALIGN and pass align from start.
> >>
> >> We are safe to do that just as we do that regular pci bridge.
> >>
> >> In the long run, we should just treat cardbus like regular pci bridge.
> >>
> >> Also fix when realloc is not passed, should keep the requested size.
> >>
> >> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> >
> > I'd like to see some testing on this one... Dominik?
> 
> Dominik,
> 
> Can you please test branch at
> 
> 	git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
> for-pci2

Tested this on my limited test systems (COUNT=1), and seems to work fine.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux