> -----Original Message----- > From: Bjorn Helgaas <bjorn.helgaas@xxxxxxxxx> > Sent: Tuesday, December 13, 2022 6:29 PM > To: Zhi Li <lznuaa@xxxxxxxxx> > Cc: Bjorn Helgaas <helgaas@xxxxxxxxxx>; Frank Li <frank.li@xxxxxxx>; > allenbh@xxxxxxxxx; dave.jiang@xxxxxxxxx; > gustavo.pimentel@xxxxxxxxxxxx; Hongxing Zhu <hongxing.zhu@xxxxxxx>; > jdmason@xxxxxxxx; jingoohan1@xxxxxxxxx; kishon@xxxxxxxxxx; > kw@xxxxxxxxx; linux-ntb@xxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; > lorenzo.pieralisi@xxxxxxx > Subject: [EXT] Re: [PATCH v2 3/4] PCI: endpoint: Support NTB transfer > between RC and EP > > Caution: EXT Email > > On Tue, Dec 13, 2022 at 6:17 PM Zhi Li <lznuaa@xxxxxxxxx> wrote: > > On Tue, Dec 13, 2022 at 6:08 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> > wrote: > >> On Tue, Feb 22, 2022 at 10:23:54AM -0600, Frank Li wrote: > >> > >> > + * +--------------------------------------------------+ Base > >> > + * | | > >> > + * | | > >> > + * | | > >> > + * | Common Control Register | > >> > + * | | > >> > + * | | > >> > + * | | > >> > + * +-----------------------+--------------------------+ Base+span_offset > >> > + * | | | > >> > + * | Peer Span Space | Span Space | > >> > + * | | | > >> > + * | | | > >> > + * +-----------------------+--------------------------+ Base+span_offset > >> > + * | | | +span_count * 4 > >> > + * | | | > >> > + * | Span Space | Peer Span Space | > >> > + * | | | > >> > + * +-----------------------+--------------------------+ > >> > >> Are these comments supposed to say *spad*, i.e., scratchpad space, > >> instead of "span", to correspond with spad_offset and spad_count > >> below? > > > > Strange, I received some of your comments on the very old patches. > > What's strange about it? I went to the trouble to look up the patch > that introduced the thing I'm asking about. I sent the email a few > minutes ago. The question still applies to the current tree. Okay, I doesn't realized you are talking about current tree also. Let me send patch to fix this soon. Best regards Frank Li > > Please use plain text email on the Linux mailing lists. > > Bjorn