RE: [patch 15/20] genirq/msi: Provide new domain id allocation functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Sent: Friday, November 18, 2022 8:26 PM
> 
> >> +	xa_for_each_range(xa, idx, desc, ctrl->first + base, ctrl->last + base) {
> >> +		if (!msi_desc_match(desc, MSI_DESC_NOTASSOCIATED))
> >> +			continue;
> >> +
> >> +		/* This should return -ECONFUSED... */
> >> +		if (WARN_ON_ONCE(allocated >= ctrl->nirqs))
> >> +			return -EINVAL;
> >> +
> >
> > why is "==" an error?
> 
> because if you get here _after_ having allocated all interrupts already
> then you have more descriptors than what you want to allocate, which
> should never happen right?

yes




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux