RE: [patch 15/20] genirq/msi: Provide new domain id allocation functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Sent: Friday, November 11, 2022 9:57 PM
> 
> @@ -597,7 +598,7 @@ static struct irq_domain *msi_get_device
>  	if (!domain)
>  		return NULL;
> 
> -	if (WARN_ON_ONCE(irq_domain_is_msi_parent(domain)))
> +	if (irq_domain_is_msi_parent(domain))
>  		return NULL;

Is it intended to remove the warning here? If yes, what specific change
in this patch leads to that removal?

> +	xa_for_each_range(xa, idx, desc, ctrl->first + base, ctrl->last + base) {
> +		if (!msi_desc_match(desc, MSI_DESC_NOTASSOCIATED))
> +			continue;
> +
> +		/* This should return -ECONFUSED... */
> +		if (WARN_ON_ONCE(allocated >= ctrl->nirqs))
> +			return -EINVAL;
> +

why is "==" an error?




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux