On Fri, Nov 18 2022 at 08:10, Kevin Tian wrote: >> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >> + if (WARN_ON_ONCE(first_index >= MSI_MAX_INDEX || last_index >= >> MSI_MAX_INDEX)) >> + return; >> + >> lockdep_assert_held(&dev->msi.data->mutex); >> >> xa_for_each_range(xa, idx, desc, first_index, last_index) { > > this doesn't belong to allocation. and next patch will convert it to > domid aware plus a formal check. Probably can just remove it > from this patch. I added this just for paranoia sake so I could catch my conversion error. So yes and no.