> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Sent: Friday, November 11, 2022 9:57 PM > > +/** > + * msi_insert_msi_desc - Allocate and initialize a MSI descriptor in the > default domain and "insert it at @init_desc->msi_index", same as the text for msi_domain_insert_msi_desc(). > @@ -183,6 +202,9 @@ void msi_free_msi_descs_range(struct dev > struct msi_desc *desc; > unsigned long idx; > > + if (WARN_ON_ONCE(first_index >= MSI_MAX_INDEX || last_index >= > MSI_MAX_INDEX)) > + return; > + > lockdep_assert_held(&dev->msi.data->mutex); > > xa_for_each_range(xa, idx, desc, first_index, last_index) { this doesn't belong to allocation. and next patch will convert it to domid aware plus a formal check. Probably can just remove it from this patch.