Hi, On Tue, Nov 15, 2022 at 12:38:11PM +1100, Albert Zhou wrote: > On 14/11/22 21:37, Mika Westerberg wrote: > > > + default y if USB4 > > > help > > > Say Y here if you have a motherboard with a PCI Hotplug controller. > > > This allows you to add and remove PCI cards while the machine is > > > - powered up and running. > > > + powered up and running. Thunderbolt and USB4 PCI cards require > > > + Hotplug. > > I would not say they "require" this. PCIe is completely optional in USB4 > > systems and it is perfectly fine to have host controllers or > > add-in-cards that don't have a single PCIe adapter. > > > > Not objeting the patch, though. For Linux I guess it makes sense to have > > this like what you are suggesting. Just perhaps changing the wordirng > > 😉 > > How about “Thunderbolt and USB4 use Hotplug” Or "Thunderbolt/USB4 PCIe tunneling needs Native PCIe Hotplug to be enabled" > Do you agree with the “default y if USB4” for PCIEPORTBUS, HOTPLUG_PCI_PCIE, HOTPLUG_PCI. Yes, I think for Linux perspective it makes sense to have them enabled by default.