Re: [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 13, 2022 at 10:28:10PM +1100, Albert Zhou wrote:
> Thunderbolt and USB4 PCI cards require the hotplug feature. This is now
> recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is
> defaulted to Y if USB4 is selected.
> 
> Signed-off-by: Albert Zhou <albert.zhou.50@xxxxxxxxx>
> ---
>  drivers/pci/hotplug/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig
> index 840a84bb5ee2..06cc373834f5 100644
> --- a/drivers/pci/hotplug/Kconfig
> +++ b/drivers/pci/hotplug/Kconfig
> @@ -6,10 +6,12 @@
>  menuconfig HOTPLUG_PCI
>  	bool "Support for PCI Hotplug"
>  	depends on PCI && SYSFS
> +	default y if USB4
>  	help
>  	  Say Y here if you have a motherboard with a PCI Hotplug controller.
>  	  This allows you to add and remove PCI cards while the machine is
> -	  powered up and running.
> +	  powered up and running. Thunderbolt and USB4 PCI cards require
> +	  Hotplug.

I would not say they "require" this. PCIe is completely optional in USB4
systems and it is perfectly fine to have host controllers or
add-in-cards that don't have a single PCIe adapter.

Not objeting the patch, though. For Linux I guess it makes sense to have
this like what you are suggesting. Just perhaps changing the wordirng
;-)



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux