Hi Angelo,
Thanks for your review.
On Wed, 2022-10-19 at 10:55 +0200, AngeloGioacchino Del Regno wrote:
> Il 17/10/22 09:08, Tinghan Shen ha scritto:
> > Add pcie and pcie phy nodes for mt8195.
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@xxxxxxxxxxxx>
> > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 143
> > +++++++++++++++++++++++
> > 1 file changed, 143 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index d03f0c2b8233..903e92d6156f 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -1182,6 +1182,104 @@
> > status = "disabled";
> > };
> >
> > + pcie0: pcie@112f0000 {
> > + compatible = "mediatek,mt8195-pcie",
> > + "mediatek,mt8192-pcie";
>
> ..snip..
>
> > +
> > + phys = <&pciephy>;
> > + phy-names = "pcie-phy";
> > +
> > + power-domains = <&spm
> > MT8195_POWER_DOMAIN_PCIE_MAC_P0>;
>
> You're missing the resets:
>
> resets = <&infracfg_ao
> MT8195_INFRA_RST2_PCIE_P0_SWRST>;
> reset-names = "mac";
>
> > +
> > + #interrupt-cells = <1>;
> > + interrupt-map-mask = <0 0 0 7>;
>
> ..snip..
>
> > + };
> > +
> > + pcie1: pcie@112f8000 {
> > + compatible = "mediatek,mt8195-pcie",
> > + "mediatek,mt8192-pcie";
>
> ..snip..
>
> > + power-domains = <&spm
> > MT8195_POWER_DOMAIN_PCIE_MAC_P1>;
>
> Here too:
> resets = <&infracfg_ao
> MT8195_INFRA_RST2_USBSIF_P1_SWRST>,
Reset the combo-phy in PCIe driver will cause side effect on USB2 port,
so this reset cannot be added.
We will fix others in the next version.
Thanks.
> <&infracfg_ao
> MT8195_INFRA_RST2_PCIE_P1_SWRST>;
> reset-names = "phy", "mac";
>
> > +
> > + #interrupt-cells = <1>;
>
> ..snip..
>
> > @@ -1241,6 +1339,34 @@
> > reg = <0x189 0x2>;
> > bits = <7 5>;
> > };
> > + pciephy_rx_ln1: pciephy-rx-ln1@190 {
> > + reg = <0x190 0x1>;
> > + bits = <0 4>;
> > + };
> > + pciephy_tx_ln1_nmos: pciephy-tx-ln1-nmos@190 {
>
> Please run dtbs_check and try to build the kernel before pushing
> commits upstream.
> This will give you a not-so-nice warning and that shall not happen.
>
> You can solve it by naming these nodes like:
> pciephy-rx-ln1@190,1
> pciephy-tx-ln1-nmos@190,2
>
> ...etc
>
> Regards,
> Angelo
>
>
