On Tue, Oct 18, 2022 at 11:51:34AM +0800, Yang Yingliang wrote:
> If device_add() fails in pci_register_host_bridge(), the bridge device will
> be put once, and it will be put again in error path of pci_create_root_bus().
> Fix this by removing put_device() after device_add() is failed.
>
> Fixes: 37d6a0a6f470 ("PCI: Add pci_register_host_bridge() interface")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/pci/probe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Seems fine. All callers, as far as I can tell, of this end up invoking
pci_free_host_bridge() which does the corresponding put_device() itself:
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
