On Sun, Jan 15, 2012 at 8:05 AM, Ram Pai <linuxram@xxxxxxxxxx> wrote: > On Fri, Jan 13, 2012 at 03:28:29PM -0800, Yinghai Lu wrote: >> On Fri, Jan 13, 2012 at 8:39 AM, Ram Pai <linuxram@xxxxxxxxxx> wrote: >> > On Wed, Dec 07, 2011 at 12:53:01AM -0800, Yinghai Lu wrote: >> > >> > I am worried that this approach will resurface old bug >> > https://bugzilla.kernel.org/show_bug.cgi?id=15960 >> >> >> so even required can not be satisfied? > > Yes. Even required cannot be satisfied fully. double check that bug, it is caused by we stop IO type too early. attached patch should fix the problem. Also I updated for-pci2 in my tree. git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci2 Peter Henriksson, Can you try for-pci2 branch on your setup with Xonar DX? also we need to ask Linus to test it, looks like Linus have one setup with Nouveau. Thanks Yinghai
Subject: [PATCH] PCI: Retry on type IORESOURCE_IO allocation. During reenabling pci reallocating for pci bridge by clean the small size in bridge and assign with requested + optional size for first several try, Ram mention could have problem with one case https://bugzilla.kernel.org/show_bug.cgi?id=15960 After checking the booting log in https://lkml.org/lkml/2010/4/19/44 [regression, bisected] Xonar DX invalid PCI I/O range since 977d17bb174 We should not stop too early for io ports. Apr 19 10:19:38 [kernel] pci 0000:04:00.0: BAR 7: can't assign io (size 0x4000) Apr 19 10:19:38 [kernel] pci 0000:05:01.0: BAR 8: assigned [mem 0x80400000-0x805fffff] Apr 19 10:19:38 [kernel] pci 0000:05:01.0: BAR 7: can't assign io (size 0x2000) Apr 19 10:19:38 [kernel] pci 0000:05:02.0: BAR 7: can't assign io (size 0x1000) Apr 19 10:19:38 [kernel] pci 0000:05:03.0: BAR 7: can't assign io (size 0x1000) Apr 19 10:19:38 [kernel] pci 0000:08:00.0: BAR 7: can't assign io (size 0x1000) Apr 19 10:19:38 [kernel] pci 0000:09:04.0: BAR 0: can't assign io (size 0x100) and clear 00:1c.0 to retry again. The patch remove the IORESOUCE_IO checking, and try one more time. and we will have chance to get allocation for 00:1c.0 io port range because from 0x4000 to 0x8000 could be used. Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> --- drivers/pci/setup-bus.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) Index: linux-2.6/drivers/pci/setup-bus.c =================================================================== --- linux-2.6.orig/drivers/pci/setup-bus.c +++ linux-2.6/drivers/pci/setup-bus.c @@ -1278,7 +1278,6 @@ pci_assign_unassigned_resources(void) struct pci_dev_resource *fail_res; unsigned long type_mask = IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_PREFETCH; - unsigned long failed_type; int pci_try_num = 1; /* don't realloc if asked to do so */ @@ -1313,16 +1312,7 @@ again: if (list_empty(&fail_head)) goto enable_and_dump; - failed_type = 0; - list_for_each_entry(fail_res, &fail_head, list) - failed_type |= fail_res->flags; - - /* - * io port are tight, don't try extra - * or if reach the limit, don't want to try more - */ - failed_type &= type_mask; - if ((failed_type == IORESOURCE_IO) || (tried_times >= pci_try_num)) { + if (tried_times >= pci_try_num) { free_list(&fail_head); goto enable_and_dump; }
