On Wed, Jul 27, 2022 at 03:02:57PM -0500, Bjorn Helgaas wrote: > On Thu, Jul 21, 2022 at 02:35:13PM -0500, Bjorn Helgaas wrote: > > On Thu, Jul 21, 2022 at 08:47:20AM +0200, Johan Hovold wrote: > > > Allow the Qualcomm PCIe controller driver to be built as a module, which > > > is useful for multi-platform kernels as well as during development. > > > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > > > > Applied to pci/ctrl/qcom for v5.20, thanks! > > I'm going to drop this one for now, since the module vs remove > discussion [1] is still ongoing. > > This patch actually makes it both *modular* and *removable*. I think > the modular part is uncontroversial and valuable by itself. > > If you want to just make it modular and *non*-removable, I think that > would be fine and we can add removability next cycle if we think it's > safe. > > [1] https://lore.kernel.org/r/20220721195433.GA1747571@bhelgaas Nah, I prefer we conclude that discussion so that hopefully this can be merged as is. Johan
