On Thu, 23 Jun 2022 21:19:48 -0700 Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > While there is a need to go from a LIBNVDIMM 'struct nvdimm' to a CXL > 'struct cxl_nvdimm', there is no use case to go the other direction. > Likely this is a leftover from an early version of the referenced commit > before it implemented devm for releasing the created nvdimm. > > Fixes: 21083f51521f ("cxl/pmem: Register 'pmem' / cxl_nvdimm devices") > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> Must be right given it builds, so no one is using it ;) FWIW: Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > --- > drivers/cxl/cxl.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index 734b4479feb2..d6ff6337aa49 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -411,7 +411,6 @@ struct cxl_nvdimm_bridge { > struct cxl_nvdimm { > struct device dev; > struct cxl_memdev *cxlmd; > - struct nvdimm *nvdimm; > }; > > /**