On Thu, 23 Jun 2022 19:45:00 -0700 Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > tl;dr: 46 patches is way too many patches to review in one sitting. Jump > to the PATCH SUMMARY below to find a subset of interest to jump into. > > The series is also posted on the 'preview' branch [1]. Note that branch > rebases, the tip of that branch at time of posting is: > > 7e5ad5cb1580 cxl/region: Introduce cxl_pmem_region objects > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git/log/?h=preview Via a W=1 build some docs are out of sync with parameter names. I'm lazy so I'll leave finding the right patch to you ;) drivers/cxl/core/region.c:1490: warning: Function parameter or member 'type' not described in 'devm_cxl_add_region' drivers/cxl/core/region.c:1719: warning: Function parameter or member 'cxlr' not described in 'devm_cxl_add_pmem_region' drivers/cxl/core/region.c:1719: warning: Excess function parameter 'host' description in 'devm_cxl_add_pmem_region' whilst here, docs for generic_nvdimm_flush() need updating to reflect generic getting added to the name in 2019... Jonathan