On 20/04/2022 16:41, Pali Rohár wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Wednesday 20 April 2022 11:34:49 Uwe Kleine-König wrote: >> There are no known reasons to not use this driver as a module, > > Hello! I think that there are reasons. pcie-microchip-host.c driver uses > builtin_platform_driver() and not module_platform_driver(); it does not > implement .remove driver callback and also has set suppress_bind_attrs > to true. I think that all these parts should be properly implemented > otherwise it does not have sane reasons to use driver as loadable and > unloadable module. > > Btw, I implemented proper module support for pci-mvebu.c driver > recently, so you can take an inspiration. See: > https://lore.kernel.org/linux-pci/20211126144307.7568-1-pali@xxxxxxxxxx/t/#u Hmm, so what is the way forward here, are you happy to do it yourself or do you not have the hardware/would rather that we did it? If you'd prefer that we did it, do we change the driver & submit that as a series with this patch as patch 2/2? Or should it be a single patch with your suggested-by? Not quite sure what the expectation is with attestation for something like this. Thanks, Conor
