On Fri, Oct 14, 2011 at 9:45 AM, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, 2011-10-14 at 09:33 -0600, Bjorn Helgaas wrote: >> On Fri, Oct 14, 2011 at 9:14 AM, James Bottomley >> <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: >> > On Thu, 2011-10-13 at 22:27 -0600, Bjorn Helgaas wrote: >> >> The most generic way to create a PCI root bus is with pci_scan_bus(), but >> >> that doesn't allow you to specify what resources are available on the bus, >> >> i.e., what the host bridge apertures are. >> > >> > Do you have an actual tree for this? The PARISC pieces look a bit >> > non-trivial and I'd like to test them out on the various sba/astro/dino >> > systems. >> >> I don't yet, but it'd be great if you were willing to test them out, >> so I'll set one up. >> >> While this is on your mind, I'm dubious about the pci_enable_bridges() >> call in lba_driver_probe() and the pci_bus_assign_resources() call in >> dino_probe(). These stand out as exceptions because no other arches >> do that. >> >> If they weren't there, both places could use pci_scan_root_bus() like >> most other arches. > > Right, the dino code actually has to rearrange some of the PCI resources > to make sure we get our apertures correct. That's the specific bit I > was planning to test. I think it's only relevant for dino SBA cards > where the bridge doesn't set up the card correctly so we have to do it > after the fact. I put these patches here: git://github.com/bjorn-helgaas/linux.git on the "pci-scan" branch. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
