On Wed, Sep 28, 2011 at 04:33:08PM -0600, Bjorn Helgaas wrote: > On Wed, Sep 21, 2011 at 3:28 AM, Yong Zhang <yong.zhang0@xxxxxxxxx> wrote: > > IRQF_DISABLED is a NOOP now, place where suggest to use this > > flag also doesn't make sense any more. > > > > Signed-off-by: Yong Zhang <yong.zhang0@xxxxxxxxx> > > I assume this will be applied via some non-PCI tree (let me know if > otherwise). The MSI-HOWTO.txt change looks fine to me. (Sorry for my late response because of long vacation) So if you could pick it up, just go ahead, otherwise tglx will take it :) > > > --- a/Documentation/scsi/ncr53c8xx.txt > > +++ b/Documentation/scsi/ncr53c8xx.txt > > @@ -786,7 +786,9 @@ port address 0x1400. > > ? ? ? ? irqm:1 ? ? same as initial settings (assumed BIOS settings) > > ? ? ? ? irqm:2 ? ? always totem pole > > ? ? ? ? irqm:0x10 ?driver will not use IRQF_SHARED flag when requesting irq > > - ? ? ? ?irqm:0x20 ?driver will not use IRQF_DISABLED flag when requesting irq > > + ? ? ? ?irqm:0x20 ?driver will not use IRQF_DISABLED (does not make sense > > + ? ? ? ? ? ? ? ? ?any more since genirq will keep irq disabled and the flag > > + ? ? ? ? ? ? ? ? ?is dead from linux-2.6.35) flag when requesting irq > > > > ? ? (Bits 0x10 and 0x20 can be combined with hardware irq mode option) > > The new text doesn't make sense to me. I think it should say something like: > > irqm:0x20 driver will not use IRQF_DISABLED flag when requesting > irq (only useful for linux-2.6.34 and earlier) Hmmm, it seems more simple :) Will update it. Thanks for your idea. Yong -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
