Hi Bjorn, Bjorn Helgaas <helgaas@xxxxxxxxxx> writes: > Koen collected some interesting logs at > https://lore.kernel.org/all/cd4812f0-1de3-0582-936c-ba30906595af@xxxxxxxxxxxx/ > They're from v5.10, which was before all of Krzysztof W's nice work > converting to static attributes, but Koen's log shows the error > happening in the pci_sysfs_init() initcall, which is *after* > imx6_pcie_probe(): > > imx6_pcie_probe # probably device initcall (level 6) > ... > pci_create_sysfs_dev_files > > pci_sysfs_init # late initcall (level 7) > pci_create_sysfs_dev_files > "sysfs: cannot create duplicate filename" Well, imx6_pcie_probe() is called indirectly by platform_driver_register(). I guess it doesn't know about the initcall ordering, after it's registered. It looks like the problem is the imx6_pcie_probe() (via dw_pcie_host_init() -> pci_host_probe()) is interfering with pci_sysfs_init(). This may eventually cause some invalid memory access as well. BTW I thought for a moment that maybe 5.14 is free from this. I was wrong. The problem doesn't manifest itself on my custom i.MX6 device (using Tinyrex CPU module from Voipac/Fedevel, perhaps because I don't use any PCI devices there). It does on Ventana SBC from Gateworks, though. BTW the above (and below) is v5.16. It goes like this: [0.096212] do_initcall_level: 6 [0.105625] imx6_pcie_init [0.106106] imx6_pcie_probe <<<<<<<<<<<<<<<<<<<<< [0.106412] imx6q-pcie 1ffc000.pcie: host bridge /soc/pcie@1ffc000 ranges: [0.322613] imx6q-pcie 1ffc000.pcie: Link up [0.322776] imx6q-pcie 1ffc000.pcie: PCI host bridge to bus 0000:00 [0.322790] pci_bus 0000:00: root bus resource [bus 00-ff] [0.405251] do_initcall_level: 6 ENDs but imx6_pcie_probe() still active [0.405262] do_initcall_level: 7 [0.410393] pci_sysfs_init <<<<<<<<<<<<<<<<<<<<< [0.410423] pci 0000:00:00.0: pci_create_sysfs_dev_files [0.410532] [<8068091c>] (pci_create_sysfs_dev_files) [0.410551] [<80918710>] (pci_sysfs_init) [0.410568] [<8010166c>] (do_one_initcall) [0.410717] pci_sysfs_init END <<<<<<<<<<<<<<<<<<<<< [0.533843] [<803f1c74>] (pci_bus_add_devices) [0.533862] [<803f574c>] (pci_host_probe) [0.533879] [<80414310>] (dw_pcie_host_init) [0.533895] [<80681ac8>] (imx6_pcie_probe) [0.533915] [<8045e9e4>] (platform_probe) (Repeats multiple times, I guess for each PCI device) [0.543893] imx6_pcie_probe END <<<<<<<<<<<<<<<<<<<<< [0.692244] do_initcall_level: 7 END -- Krzysztof "Chris" Hałasa Sieć Badawcza Łukasiewicz Przemysłowy Instytut Automatyki i Pomiarów PIAP Al. Jerozolimskie 202, 02-486 Warszawa
