> -----Original Message-----
> From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Sent: 2022年2月9日 17:08
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>; bhelgaas@xxxxxxxxxx;
> lorenzo.pieralisi@xxxxxxx; shawnguo@xxxxxxxxxx
> Cc: linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>
> Subject: Re: [RFC 2/2] PCI: imx6: Enable imx6qp pcie power management
> support
>
> s/pcie/PCIe/ and maybe s/imx6qp/i.MX6QP/ in the subject.
Thanks, would be changed later.
>
> Am Mittwoch, dem 09.02.2022 um 15:02 +0800 schrieb Richard Zhu:
> > i.MX6QP PCIe supports the RESET logic, thus it can support the L2 exit
> > by the reset mechanism.
> > Enable the i.MX6QP PCIe suspend/resume operations support.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
>
> Other than the nitpick:
> Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
Thanks.
Best Regards
Richard Zhu>
> > ---
> > drivers/pci/controller/dwc/pci-imx6.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> > b/drivers/pci/controller/dwc/pci-imx6.c
> > index 784801f2f9e6..62262483470a 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -995,6 +995,7 @@ static void imx6_pcie_pm_turnoff(struct imx6_pcie
> *imx6_pcie)
> > /* Others poke directly at IOMUXC registers */
> > switch (imx6_pcie->drvdata->variant) {
> > case IMX6SX:
> > + case IMX6QP:
> > regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> > IMX6SX_GPR12_PCIE_PM_TURN_OFF,
> > IMX6SX_GPR12_PCIE_PM_TURN_OFF);
> > @@ -1307,7 +1308,8 @@ static const struct imx6_pcie_drvdata drvdata[] =
> {
> > [IMX6QP] = {
> > .variant = IMX6QP,
> > .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> > - IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
> > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
> > + IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
> > .dbi_length = 0x200,
> > },
> > [IMX7D] = {
>
