Follow subject line convention (s/fix/Fix/, s/gpios/GPIOs/). On Fri, Feb 04, 2022 at 05:38:21PM +0000, Ben Dooks wrote: > The calls to devm_gpiod_get_optional() have the -gpios on > the name. This means the pcie driver is not finding the > necessary reset or power gpios to allow the pcie devices > on the SiFive Unmatched boards. > > Note, this was workng around 5.16 and may not have been > broken? There is still an issue if uboot has not probed > the pcie bus then there are no pcie devices shown when > Linux is started. Wrap to fill 75 columns s/gpios/GPIOs/ s/pcie/PCIe/ s/workng/working/ s/to allow the pcie devices/to allow the PCIe devices <to something>?/ I can't tell what this is saying. It used to work and something broke it? If so, we should have a "Fixes:" tag to identify the commit that broke it. Or it used to work and "may *not* have been broken"? I'm confused. Unclear how uboot is involved. > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> > --- > drivers/pci/controller/dwc/pcie-fu740.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c > index 00cde9a248b5..842b7202b96e 100644 > --- a/drivers/pci/controller/dwc/pcie-fu740.c > +++ b/drivers/pci/controller/dwc/pcie-fu740.c > @@ -259,11 +259,11 @@ static int fu740_pcie_probe(struct platform_device *pdev) > return PTR_ERR(afp->mgmt_base); > > /* Fetch GPIOs */ > - afp->reset = devm_gpiod_get_optional(dev, "reset-gpios", GPIOD_OUT_LOW); > + afp->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); > if (IS_ERR(afp->reset)) > return dev_err_probe(dev, PTR_ERR(afp->reset), "unable to get reset-gpios\n"); > > - afp->pwren = devm_gpiod_get_optional(dev, "pwren-gpios", GPIOD_OUT_LOW); > + afp->pwren = devm_gpiod_get_optional(dev, "pwren", GPIOD_OUT_LOW); > if (IS_ERR(afp->pwren)) > return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n"); > > -- > 2.34.1 >
