On 21-11-22 18:19:01, Jonathan Cameron wrote: > On Fri, 19 Nov 2021 16:02:50 -0800 > Ben Widawsky <ben.widawsky@xxxxxxxxx> wrote: > > > Switches aren't supported by the region driver yet. If a device finds > > itself under a switch it will not bind a driver so that it cannot be > > used later for region creation/configuration. > > What's the reasoning in have this in this patch set rather than the region one? > > I was rather hoping you'd have it working when the region set is ready :) > > Jonathan > I'm uncomfortable enabling it until I actually have an environment to test it in. If Dan et al. don't mind however, I can drop this patch. > > > > Signed-off-by: Ben Widawsky <ben.widawsky@xxxxxxxxx> > > --- > > drivers/cxl/mem.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c > > index e954144af4b8..997898e78d63 100644 > > --- a/drivers/cxl/mem.c > > +++ b/drivers/cxl/mem.c > > @@ -155,6 +155,11 @@ static int cxl_mem_probe(struct device *dev) > > goto out; > > } > > > > + /* FIXME: Add true switch support */ > > + dev_err(dev, "Devices behind switches are currently unsupported\n"); > > + rc = -ENODEV; > > + goto err_out; > > + > > /* Walk down from the root port and add all switches */ > > cxl_scan_ports(ctx.root_port); > > >
