On Thursday 28 October 2021 12:30:30 Lorenzo Pieralisi wrote: > On Thu, Oct 28, 2021 at 01:13:02PM +0200, Pali Rohár wrote: > > [...] > > > > > In commit message I originally tried to explain it that after applying > > > > all previous patches which are fixing MSI and Multi-MSI support (part of > > > > them is enforcement to use only MSI numbers 0..31), it makes driver > > > > compatible with also MSI-X interrupts. > > > > > > > > If you want to rewrite commit message, let us know, there is no problem. > > > > > > I think we should. > > > > > > > > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > > > > > > Reviewed-by: Marek Behún <kabel@xxxxxxxxxx> > > > > > > By the way, this tag should be removed. Marek signed it off, that > > > applies to other patches in this series as well. > > > > Ok! Is this the only issue with this patch series? Or something other > > needs to be fixed? > > The series looks fine to me - only thing for patch[4-10] I'd like > to have evidence MarcZ is happy with the approach Marc, could you look at patches 4-10 if you are happy with them? Link: https://lore.kernel.org/linux-pci/20211012164145.14126-5-kabel@xxxxxxxxxx/ > (you have an > ACK on patch 9, for other patches if they were discussed on > ML add a Link: tag to the relevant discussion please). Only that one patch was acked in past: https://lore.kernel.org/linux-pci/87a6p6q1r9.wl-maz@xxxxxxxxxx/ > I am trying to keep the IRQ domain management in PCI controller > drivers in check, that's why I am asking. > > I can definitely pull [1-3] and [11-14] since they look good to me. Ok! > Thanks, > Lorenzo > > > > > > Lorenzo > > > > > > > > > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx> > > > > > > --- > > > > > > drivers/pci/controller/pci-aardvark.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > > > > > index b703b271c6b1..337b61508799 100644 > > > > > > --- a/drivers/pci/controller/pci-aardvark.c > > > > > > +++ b/drivers/pci/controller/pci-aardvark.c > > > > > > @@ -1274,7 +1274,7 @@ static int advk_pcie_init_msi_irq_domain(struct advk_pcie *pcie) > > > > > > > > > > > > msi_di = &pcie->msi_domain_info; > > > > > > msi_di->flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > > > > > > - MSI_FLAG_MULTI_PCI_MSI; > > > > > > + MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX; > > > > > > msi_di->chip = msi_ic; > > > > > > > > > > > > pcie->msi_inner_domain = > > > > > > -- > > > > > > 2.32.0 > > > > > >
