question about PCI_EXP_TYPE_RC_EC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yu,

We added PCI_EXP_TYPE_RC_EC in 1b6b8ce2ac37 "PCI: only save/restore
existent registers in the PCIe capability"  We always compare whether
PCI_EXP_TYPE_RC_EC is equal to dev->pcie_type or not.  But since
PCI_EXP_TYPE_RC_EC is higher than pcie_type can possibly be, they are
never equal.

Here is how the data types are defined:
#define  PCI_EXP_TYPE_RC_EC     0x10    /* Root Complex Event Collector */

and:
	u8              pcie_type:4;    /* PCI-E device/port type */

Since 0x10 is greater than 0xf the two are never equal.

What was intended here?

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux