Hi! > > Thank you for the comments, Dan. > > > > I originally did submit something simple that just added a couple of > > sysfs attributes to allow userspace access to the _DSM, but Greg K-H > > said (1) that I shouldn't create new driver-specific sysfs files that do > > things that existing class drivers do, and that if I'm allowing LEDs to > > be controlled by the user, I have to use the LED subsystem, so I went > > with that. (See the end of > > https://patchwork.ozlabs.org/project/linux-pci/patch/20201110153735.58587-1-stuart.w.hayes@xxxxxxxxx/) > > I agree with the general sentiment to adopt and extend existing ABIs > wherever possible, it's just not clear to me that the LED class driver > is the best fit. The Enclosure class infrastructure, in addition to LED drivers are not good fit for this. It is unlikely to be accepted. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: PGP signature
