On Thu, 07 Jul 2011 19:44:16 +0900 Naoki Yanagimoto <yanagimoto@xxxxxxxxxxxxxxxxxx> wrote: > (2011/07/05 17:43), Kenji Kaneshige wrote: > > (2011/07/05 17:01), Naoki Yanagimoto wrote: > >> From: Naoki Yanagimoto<yanagimoto@xxxxxxxxxxxxxxxxxx> > >> > >> I got a problem that an abnormal value was returned from the configuration > >> space of some PCIe card at hotadd. The pciehp driver regarded the function of > >> the device as being unavailable, so the card did not work. The problem > >> disappeared when I simply added 1 second wait without using DLLLA. > >> > >> I think that it should wait for 1 second because "PCI Express Base > >> Specification Revision 3.0" says, "the software must wait for at least > >> 1 second to judge device is broken after Data Link Layer State Changed Event". > >> > > > > I think you are right. > > > >> Therefore, I send a patch that drops DLLLA checking and adds 1 second wait. > > > > But I think DLLLA checking is still required. I think we need the following things. > > > > - Wait for Data Link Layer State Changed event. > > - Wait for at least 1 second to judge device is broken after Data Link > > Layer State Changed Event > > > > Your patch does only the latter. I think we also need the former. > > What do you think about the following change? Could you try it? > > Please note that I've not tested it at all. Sorry... > > I absolutely agree with you. > I tested it. The problem did not occur. It looks good! > > Tested-by: Naoki Yanagimoto <yanagimoto@xxxxxxxxxxxxxxxxxx> Great, thanks guys. Can one of you re-post both with updated changelogs and proper signed-off-bys? Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
