Re: [PATCH] PCI: fix a scheduling in atomic bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 12, 2021 at 09:19:42AM -0600, Logan Gunthorpe wrote:
> 
> 
> 
> On 2021-08-12 1:00 a.m., Dan Carpenter wrote:
> > This function is often called with a spinlock held so the allocation has
> > to be atomic.  The call tree is:
> > 
> > pci_specified_resource_alignment() <-- takes spin_lock();
> >  -> pci_dev_str_match()
> >     -> pci_dev_str_match_path()
> > 
> > Fixes: 07d8d7e57c28 ("PCI: Make specifying PCI devices in kernel parameters reusable")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> This looks good to me, but I think the fixes tag is wrong.
> pci_dev_str_match_path() was introduced in this patch:
> 
> Fixes: 45db33709ccc ("PCI: Allow specifying devices using a base bus and
> path of devfns")

Yeah.  You're right.  Thanks.  Thanks, Bjorn for fixing this.

regards,
dan carpenter




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux