On 2021-08-12 1:00 a.m., Dan Carpenter wrote: > This function is often called with a spinlock held so the allocation has > to be atomic. The call tree is: > > pci_specified_resource_alignment() <-- takes spin_lock(); > -> pci_dev_str_match() > -> pci_dev_str_match_path() > > Fixes: 07d8d7e57c28 ("PCI: Make specifying PCI devices in kernel parameters reusable") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> This looks good to me, but I think the fixes tag is wrong. pci_dev_str_match_path() was introduced in this patch: Fixes: 45db33709ccc ("PCI: Allow specifying devices using a base bus and path of devfns") Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx> Thanks, Logan