On Wed, Jun 08, 2011 at 05:17:38AM -0400, David Woodhouse wrote: > On Wed, 2011-06-08 at 11:34 +0300, Ohad Ben-Cohen wrote: > > --- a/drivers/pci/Makefile > > +++ b/drivers/pci/Makefile > > @@ -30,7 +30,7 @@ obj-$(CONFIG_PCI_MSI) += msi.o > > obj-$(CONFIG_HT_IRQ) += htirq.o > > > > # Build Intel IOMMU support > > -obj-$(CONFIG_DMAR) += dmar.o iova.o intel-iommu.o > > +obj-$(CONFIG_DMAR) += dmar.o iova.o > > > > obj-$(CONFIG_INTR_REMAP) += dmar.o intr_remapping.o > > > > At least iova.o wants to go with it. That's one of the parts that is a > candidate for harmonisation across IOMMU implementations, either by > removing it or by having others use it too. It's how we allocate virtual > I/O address space. > > I suspect the interrupt remapping support may well want to move with it > too. It's no more out-of-place in drivers/iommu than it is in > drivers/pci. And then you can certainly move dmar.o too. Interrupt remapping certainly makes sense too. I am not sure yet how to generalize it because the AMD version of it is significantly different from VT-d, but we'll see. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html