On Thu, Jul 01, 2021 at 10:44:01PM +0200, Krzysztof Wilczyński wrote: > At the moment, the switch statement in the artpec6_pcie_probe() has > a local code block where the local variable "val" is defined and > immediately used by the artpec6_pcie_readl() within this local scope. > > This extra code block adds brackets at the same indentation level as the > switch statement itself which can hinder readability of the code. > > Thus, move the variable "val" declaration and definition at the top of > the function where other variables are already present, and remove the > extra code block from within the select statement. This also is the > preferred style in the PCI tree. > > Suggested-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Signed-off-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx> /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@xxxxxxxx