Re: [PATCH] PCI: artpec6: Remove surplus break statement after return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

[...]
> According to
> 
>   $ git grep -n -A1 "return.*;" drivers/pci
> 
> there's at least one more instance in
> drivers/pci/controller/dwc/pcie-designware-plat.c.

Nice find!  I will send a patch shortly.  Thank you!

[...]
> >  		pci->ep.ops = &pcie_ep_ops;
> >  
> >  		return dw_pcie_ep_init(&pci->ep);
> > -		break;
> >  	}
> 
> Not related to your patch, but I'm not really a fan of the block here
> (needed because of the local "u32 val" declaration) because we end up
> with two close braces at the same indent level.  I'd rather declare
> the variable at the top with the other local variables and dispense
> with the braces.

No problem!  I will sent v2 to take care of this too in the same time.

	Krzysztof



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux