Hi Pali, On 22/06/21 13:06, Pali Rohár wrote: > Hello! > > On Tuesday 22 June 2021 12:57:22 Luca Ceresoli wrote: >> Nothing happened after a few weeks... I understand that knowing the >> correct reset timings is relevant, but unfortunately I cannot help much >> in finding out the correct values. >> >> However I'm wondering what should happen to this patch. It *does* fix a >> real bug, but potentially with an incorrect or non-optimal usleep range. >> Do we really want to ignore a bugfix because we are not sure about how >> long this delay should be? > > As there is no better solution right now, I'm fine with your patch. But > patch needs to be approved by Lorenzo, so please wait for his final > answer. > > I would suggest to add a comment for call "usleep_range(1000, 2000);" > that you have chosen some "random" values which worked fine on your > setup and that they fix mentioned bug. Comment just to mark this sleep > code that is suboptimal / not-so-correct and to prevent other people to > copy+paste this code into other (new) drivers... Sure, good idea. I'm following this thread and will send v3 after a direction is agreed upon. -- Luca
