> + if (!(bridge->pcie_devcap2 & PCI_EXP_DEVCAP2_ATOMIC_ROUTE)) Overly long line. > +static void pci_init_devcap2(struct pci_dev *dev) > +{ > + if (!pci_is_pcie(dev)) > + return; > + > + pcie_capability_read_dword(dev, PCI_EXP_DEVCAP2, &dev->pcie_devcap2); > +} Wouldn't it make sene to merge this into set_pcie_port_type?